Avoid rebuild old FindTrackedObjectsInJson into json CalculateDiff - #11631
Open
PolEpie wants to merge 1 commit into
Open
Avoid rebuild old FindTrackedObjectsInJson into json CalculateDiff#11631PolEpie wants to merge 1 commit into
PolEpie wants to merge 1 commit into
Conversation
5 tasks
Contributor
|
Good idea, but i don't like the fact though that we are making diffing internals public/internal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Thanks for contributing to s&box ❤️
Please fill out the sections below to help us review your change efficiently.
Summary / Motivation & Context
This is part of a big finding on my #11630 issue

So i saw that FindTrackedObjectsInJson was called twice and did it with old / new, and i was like hmm, couldnt that being cached ?
Implementation Details
So my pr is simple, into PrefabCacheScene.Load, we calculate the Json.BuildTrackedObjects directly, and use it on FindTrackedObjectsInJson instead of recalculate it.
Anyway once a prefab is saved it's gonna recall load and update it
Checklist