Add terrain storage change synchronization - #11666
Open
aidencurtis wants to merge 1 commit into
Open
Conversation
antopilo
added
the
triaged
Add ApplyStorageChanges to upload CPU edits, refresh collision, and notify terrain-dependent systems through a single path. Use it for brush undo/redo and texture painting, preserving half-open dirty-region bounds at terrain edges. Add integration coverage for notification ordering, collision-only updates, and final-row/final-column synchronization.
aidencurtis
force-pushed
the
terrain-undo-fix
branch
from
August 15, 2026 23:39
43b761a to
53ae219
Compare
handsomematt
added
triaged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Thanks for contributing to s&box ❤️
Please fill out the sections below to help us review your change efficiently.
Summary
Adds
ApplyStorageChangeswhich applies storage changes to collision and rendering and notifies terrain-dependent systems.Previously, modifying terrain would trigger
OnTerrainModified, but using the undo feature in the editor would not. This centralizes the storage changes triggered by the Undo process to prevent future drift and alerts terrain-dependent systems like normal terrain operations.Motivation & Context
Editor user experience improvement. Without this change, systems subscribing to
OnTerrainModifiedwould not be notified appropriately when a terrain change was undone via the Undo system.Implementation Details
Screenshots / Videos (if applicable)
Checklist