[Terrain] Refactor so tmat use Texture instead of string - #11673
Open
PolEpie wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Thanks for contributing to s&box ❤️
Please fill out the sections below to help us review your change efficiently.
Summary
Before you could only put path to a texture and it fetched it, but no operation were possible unlike what Decals have with builtin Texture type
Motivation & Context
I wanted a way to add roughness easily #11510 but then wheatley point out that adding this feature would be better than just a roughness slider
Implementation Details
So i did a huge refactor cause we gotta do a json upgrade, but basically i changed every slot for Texture type, a upgrader and i did change how we generate the texture then, so i unify the template (thx jean claude) and create Bitmap.PackChannel so we can build the baked texture easily
Screenshots / Videos (if applicable)
Now :

Checklist