Fix PositionToValue() for EditorCurve.Handle when curve length <= 1 - #11690
Open
LeDernierPoisson wants to merge 2 commits into
Open
Fix PositionToValue() for EditorCurve.Handle when curve length <= 1#11690LeDernierPoisson wants to merge 2 commits into
LeDernierPoisson wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…is set
Pull Request
Thanks for contributing to s&box ❤️
Please fill out the sections below to help us review your change efficiently.
Summary
This fixes a bug with the curve editor where if you have only 1 keyframes set , the computed value of PositionToValue() for any consumer would be the square root of what it should actually be
Motivation & Context
This is clearly a bug and makes it really annoying to play with curves. This bug also caused an unstable state to the range curves, even with multiple keyframes set, the computed value was of. Now since you can't have that behaviour again the curve with ranges never gets in this state
Fixes:
Implementation Details
Looking at it I realized it was pretty straightforward. A guarding prevented normalization of the time and value viewport ranges if the curve length was less or equal to 1 . Simply removing the guard fixed it and it didn't introduce any bug on all my tests. It also fixed the same issue for curve ranges so that's a win win
Screenshots / Videos (if applicable)
Before
Bugge-Curve-Range.mp4
After
Bugged-Curve-Range-Fix.mp4
Checklist