Qol for curve presets - #11692
Open
LeDernierPoisson wants to merge 1 commit into
Open
Conversation
- Keep the current range of the edited curve when applying a preset - Apply the preset range on the edited curve usin a right click option on the preset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Thanks for contributing to s&box ❤️
Please fill out the sections below to help us review your change efficiently.
Summary
This pr aims to improve the usage of presets on curves
Now if you click on a preset the curve editor will keep the current range by default.
The old mechanism has been moved to a right click option on the preset
Motivation & Context
I saw @Fortune117 issue on the matter and I totally agree with his opinion because what interests me 80% of the time is the shape of a preset but with my current range. But i do still think havin ranges on the presets is a good idea just for reusability purposes. Moving it to a right click option is the best moovee in my opinion
Fixes: #1546
Implementation Details
Nothing specific that should be noted else than the fact I added summaries to the already present OnCurveClicked property and the two new ones I created to explicit their role without having to use complex property names. I think it's better, if you disagree I can remove them.
Screenshots / Videos (if applicable)
Before
presets-before-fix.mp4
After
Presets-After-Fix.mp4
Checklist