Skip to content

Qol for curve presets - #11692

Open
LeDernierPoisson wants to merge 1 commit into
Facepunch:masterfrom
LeDernierPoisson:curve-preset-range-upgrade
Open

Qol for curve presets#11692
LeDernierPoisson wants to merge 1 commit into
Facepunch:masterfrom
LeDernierPoisson:curve-preset-range-upgrade

Conversation

@LeDernierPoisson

@LeDernierPoisson LeDernierPoisson commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Pull Request

Thanks for contributing to s&box ❤️
Please fill out the sections below to help us review your change efficiently.


Summary

This pr aims to improve the usage of presets on curves
Now if you click on a preset the curve editor will keep the current range by default.
The old mechanism has been moved to a right click option on the preset

Motivation & Context

I saw @Fortune117 issue on the matter and I totally agree with his opinion because what interests me 80% of the time is the shape of a preset but with my current range. But i do still think havin ranges on the presets is a good idea just for reusability purposes. Moving it to a right click option is the best moovee in my opinion

Fixes: #1546

Implementation Details

Nothing specific that should be noted else than the fact I added summaries to the already present OnCurveClicked property and the two new ones I created to explicit their role without having to use complex property names. I think it's better, if you disagree I can remove them.

Screenshots / Videos (if applicable)

Before

presets-before-fix.mp4

After

Presets-After-Fix.mp4

Checklist

  • Code follows existing style and conventions
  • No unnecessary formatting or unrelated changes
  • Public APIs are documented (if applicable)
  • Unit tests added where applicable and all passing
  • I’m okay with this PR being rejected or requested to change 🙂

- Keep the current range of the edited curve when applying a preset

- Apply the preset range on the edited curve usin a right click option on the preset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clicking any of the curve presets in the new curve editor resets the y values to 0 and 1

2 participants