Skip to content

Curve editor multiselect drag correctly clamped when out of bounds - #11693

Open
LeDernierPoisson wants to merge 1 commit into
Facepunch:masterfrom
LeDernierPoisson:curve-multiselect-drag-clamp
Open

Curve editor multiselect drag correctly clamped when out of bounds#11693
LeDernierPoisson wants to merge 1 commit into
Facepunch:masterfrom
LeDernierPoisson:curve-multiselect-drag-clamp

Conversation

@LeDernierPoisson

Copy link
Copy Markdown
Contributor

Pull Request

Thanks for contributing to s&box ❤️
Please fill out the sections below to help us review your change efficiently.


Summary

Changes how the curve editor handles dragging multiple keyframes out of the range.

Previously , when having multiple keyframes selected and dragging them together, if you would hit the ranges bound with some keyframes they would get clamped and all the other would continue to move. Now if you do that all the keyframes will be clamped as soon as one keyframe in the selection is getting out of bounds

Motivation & Context

The old behaviour was really a pain in the ass and made me stop using this feature at all.
The principle reason is that I would often "break" the shape of the selected keyframes when i wanted to drag near the bounds. Coupled to the fact we don't have undo's and redo's on this widget it made for a really destructive feature ,especially when you wanted to move a big selection of keyframes.

Screenshots / Videos (if applicable)

Before

Curve-Multiselect-Before-Fix.mp4

After

Curve-Multiselect-After-Ix.mp4

Checklist

  • Code follows existing style and conventions
  • No unnecessary formatting or unrelated changes
  • Public APIs are documented (if applicable)
  • Unit tests added where applicable and all passing
  • I’m okay with this PR being rejected or requested to change 🙂

When dragging multiple keyframes at a time, clamp all the selected keyframes if one of the keyframes goes out of range
@LeDernierPoisson LeDernierPoisson changed the title Multiple drag clamps correctly Curve editor multiselect drag correctly clamped when out of bounds Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants