Curve editor multiselect drag correctly clamped when out of bounds - #11693
Open
LeDernierPoisson wants to merge 1 commit into
Open
Curve editor multiselect drag correctly clamped when out of bounds#11693LeDernierPoisson wants to merge 1 commit into
LeDernierPoisson wants to merge 1 commit into
Conversation
When dragging multiple keyframes at a time, clamp all the selected keyframes if one of the keyframes goes out of range
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Thanks for contributing to s&box ❤️
Please fill out the sections below to help us review your change efficiently.
Summary
Changes how the curve editor handles dragging multiple keyframes out of the range.
Previously , when having multiple keyframes selected and dragging them together, if you would hit the ranges bound with some keyframes they would get clamped and all the other would continue to move. Now if you do that all the keyframes will be clamped as soon as one keyframe in the selection is getting out of bounds
Motivation & Context
The old behaviour was really a pain in the ass and made me stop using this feature at all.
The principle reason is that I would often "break" the shape of the selected keyframes when i wanted to drag near the bounds. Coupled to the fact we don't have undo's and redo's on this widget it made for a really destructive feature ,especially when you wanted to move a big selection of keyframes.
Screenshots / Videos (if applicable)
Before
Curve-Multiselect-Before-Fix.mp4
After
Curve-Multiselect-After-Ix.mp4
Checklist