Fix Asset Browser clearing on Asset recompile#27
Closed
trende2001 wants to merge 1 commit intoFacepunch:masterfrom
Closed
Fix Asset Browser clearing on Asset recompile#27trende2001 wants to merge 1 commit intoFacepunch:masterfrom
trende2001 wants to merge 1 commit intoFacepunch:masterfrom
Conversation
trende2001
force-pushed
the
assetbrowser-fix-assetlist
branch
2 times, most recently
from
3e8058a to
08da0d5
Compare
Member
|
This is an awful lot of undocumented code for something that sounds so simple |
Contributor
Author
This fixed my issue but I can simplify it further of course |
trende2001
force-pushed
the
assetbrowser-fix-assetlist
branch
from
08da0d5 to
4a3750b
Compare
Contributor
Author
|
@garrynewman What about now? I've simplified it to 2 methods, just capture the scroll position and restore it, and documented them. |
trende2001
changed the title
trende2001
changed the title
trende2001
changed the title
|
The problem this fixes is extremely annoying and the code looks pretty good to me. |
Contributor
Author
|
I would like for this to get re-reviewed. |
trende2001
force-pushed
the
assetbrowser-fix-assetlist
branch
from
18ec120 to
97aa851
Compare
trende2001
force-pushed
the
assetbrowser-fix-assetlist
branch
4 times, most recently
from
382eec2 to
0dd0ce5
Compare
trende2001
force-pushed
the
assetbrowser-fix-assetlist
branch
2 times, most recently
from
9002d37 to
00c0ef5
Compare
handsomematt
requested changes
Jan 15, 2026
Member
handsomematt
left a comment
handsomematt
left a comment
There was a problem hiding this comment.
Why does the asset browser go to the top after a recompile - we should look at that instead of hacking in a position restore
trende2001
force-pushed
the
assetbrowser-fix-assetlist
branch
2 times, most recently
from
1747e09 to
faad082
Compare
trende2001
changed the title
trende2001
force-pushed
the
assetbrowser-fix-assetlist
branch
from
faad082 to
507c192
Compare
handsomematt
approved these changes
Jan 20, 2026
trende2001
force-pushed
the
assetbrowser-fix-assetlist
branch
from
507c192 to
9c06902
Compare
handsomematt
added
the
triaged
Contributor
|
This PR has been merged upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes an unnecessary AssetList.Clear() call in UpdateAssetListAsync.
Resolves #829