Fix gibs being network spawned multiple times#34
Closed
Nolankicks wants to merge 1 commit intoFacepunch:masterfrom
Closed
Fix gibs being network spawned multiple times#34Nolankicks wants to merge 1 commit intoFacepunch:masterfrom
Nolankicks wants to merge 1 commit intoFacepunch:masterfrom
Conversation
Member
|
This makes sense to me |
garrynewman
added
the
triaged
Contributor
|
This PR has been merged upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where gibs would be spawned multiple times over the network. The core issue of the code was calling
.NetworkSpawnon a gib component. This was called in an rpc, and there no check to only.NetworkSpawnthe gib only on the owner of the object. Without this check, the.NetworkSpawnmethod would be called multiple times, which spawned extra gibs for every client. This PR fixes this by checking!IsProxyinCreateGibs(), which makes only the owner of the prop spawn the gibs.