Fix CheckValidationAttributes call within ReviewWizardPage not outputting all error messages#35
Closed
TrvsF wants to merge 8 commits intoFacepunch:masterfrom
Closed
Fix CheckValidationAttributes call within ReviewWizardPage not outputting all error messages#35TrvsF wants to merge 8 commits intoFacepunch:masterfrom
TrvsF wants to merge 8 commits intoFacepunch:masterfrom
Conversation
|
looks like a very useful pr, i think Ive gotten stuck here once or twice... |
handsomematt
added
the
triaged
Contributor
|
This PR has been merged upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i was getting a silent error when trying to publish a project with a Title above 32 characters
this change makes any errors that occur when Project.Config contains invalid properties appear to the user