Skip to content

Add effects drawing for underline/strikethrough styles#50

Closed
aidencurtis wants to merge 1 commit intoFacepunch:masterfrom
aidencurtis:draw-text-decoration-shadows
Closed

Add effects drawing for underline/strikethrough styles#50
aidencurtis wants to merge 1 commit intoFacepunch:masterfrom
aidencurtis:draw-text-decoration-shadows

Conversation

@aidencurtis
Copy link
Copy Markdown
Contributor

Resolves #1704

Summary

  • Paints underlines and strikethroughs with TextEffects to allow for shadows to be drawn for text-decoration styles.

Before:
image

After:
image

@aidencurtis
Copy link
Copy Markdown
Contributor Author

I'd like to add some visual UI tests for this, but I can't seem to find them anymore. Let me know if there is a good place to test this change!

@DevulTj DevulTj added the triaged triaged pull-requests are replicated on the internal sbox repo label Nov 28, 2025
@sboxbot sboxbot added the accepted this pull request was accepted, hurrah! label Nov 28, 2025
@sboxbot
Copy link
Copy Markdown
Contributor

sboxbot commented Nov 28, 2025

This PR has been merged upstream.

@sboxbot sboxbot closed this Nov 28, 2025
@aidencurtis aidencurtis deleted the draw-text-decoration-shadows branch November 30, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted this pull request was accepted, hurrah! triaged triaged pull-requests are replicated on the internal sbox repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

text-shadow does not apply to text-decoration

3 participants