Fix: Properly destroy Scene in MapWorld to prevent memory leak#81
Closed
PatrickJnr wants to merge 1 commit intoFacepunch:masterfrom
Closed
Fix: Properly destroy Scene in MapWorld to prevent memory leak#81PatrickJnr wants to merge 1 commit intoFacepunch:masterfrom
PatrickJnr wants to merge 1 commit intoFacepunch:masterfrom
Conversation
handsomematt
added
triaged
handsomematt
force-pushed
the
fix/mapworld-memory-leak
branch
from
5d2595b to
97e71f0
Compare
handsomematt
removed
the
triaged
Contributor
Author
|
Thanks @handsomematt |
handsomematt
added
the
triaged
PatrickJnr
force-pushed
the
fix/mapworld-memory-leak
branch
from
cbf5852 to
4a733d1
Compare
handsomematt
added
triaged
handsomematt
force-pushed
the
fix/mapworld-memory-leak
branch
from
4a733d1 to
e309743
Compare
handsomematt
added
triaged
Contributor
|
This PR has been merged upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a
FIXMEin MapWorld.cs where the Scene wasn't being properly destroyed.Previously, the reference was set to
null, which meant the Scene (and its native resources) hung around until the GC decided to run. This change ensuresScene.Destroy()is called immediately when the MapWorld is destroyed.