Fix: Clarify Attributes property caching in SceneObject#96
Closed
PatrickJnr wants to merge 1 commit intoFacepunch:masterfrom
Closed
Fix: Clarify Attributes property caching in SceneObject#96PatrickJnr wants to merge 1 commit intoFacepunch:masterfrom
PatrickJnr wants to merge 1 commit intoFacepunch:masterfrom
Conversation
- Changed from null-coalescing operator to explicit null check - Makes caching behavior more clear and maintainable - Verified same RenderAttributes instance returned on multiple accesses
|
Regarding the removed comment:
Regarding the change to null checking:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Attributes property had a FIXME about allocating
CSceneObject::m_pExtraDataeven when only reading. Although the??=operator cached the value, the behaviour wasn't explicit.Solution
Changed to an explicit
if (_attributes == null)check for clarity and removed the misleading FIXME comment.Testing
The test file was removed before committing.
Verified that multiple accesses to Attributes return the same cached instance.