Add formatting to indicate state of sound preview toggle buttons#99
Closed
boxrocket6803 wants to merge 3 commits intoFacepunch:masterfrom
Closed
Add formatting to indicate state of sound preview toggle buttons#99boxrocket6803 wants to merge 3 commits intoFacepunch:masterfrom
boxrocket6803 wants to merge 3 commits intoFacepunch:masterfrom
Conversation
|
Great tooltip icons. |
handsomematt
requested changes
Dec 11, 2025
Member
handsomematt
left a comment
handsomematt
left a comment
There was a problem hiding this comment.
Really bad way to do it, making a Bitmap and setting that as the new icon in Toggled...
It's nice but it'd need to be a common button style on the Toolbar.AddOption button, and override Paint instead
Contributor
Author
|
Seemed like Toolbar and Option are all in native qt and a pain to mess with. Noticed I could just replace them all with IconButton instead though, feels cleaner |
handsomematt
added
the
triaged
boxrocket6803
force-pushed
the
sound-preview-buttons
branch
from
67f24d6 to
96e0a8e
Compare
Contributor
|
This PR has been merged upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #918
Loop and Auto-Play buttons in sound preview previously had no indication as to their state, this adds a stylish blue background to those buttons when they are enabled
