Skip to content

Tutor Registration Form #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Apr 24, 2025
Merged

Tutor Registration Form #92

merged 20 commits into from
Apr 24, 2025

Conversation

Plebysnacc
Copy link
Contributor

Things that were implemented:

  • Form to give us contact data and availableEvents
  • user friendly errors
  • comments at weird points to help out new members of the group

Things to consider

  • the error handling is still vague, I'll look over it with @dheidemann next time we see each other in person
  • long emails may break the success window, gotta look that one up

@Plebysnacc Plebysnacc linked an issue Apr 13, 2025 that may be closed by this pull request
Page: Tutor registration form #85
Closed
3 tasks
@Plebysnacc
Copy link
Contributor Author

Apparently I have to get the Users SID first before inserting the availabilities

@Plebysnacc Plebysnacc added enhancement New feature or request frontend labels Apr 15, 2025
@github-project-automation github-project-automation bot moved this to Todo in pepp Apr 15, 2025
@Plebysnacc
Copy link
Contributor Author

Needs Review, error handling should be discussed, but we could push that to another issue

@Plebysnacc Plebysnacc marked this pull request as ready for review April 17, 2025 16:01
@Plebysnacc Plebysnacc requested a review from dheidemann April 17, 2025 16:02
dheidemann
dheidemann requested changes Apr 17, 2025
View reviewed changes
Copy link
Member

@dheidemann dheidemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job! Could you please have a look at the mobile view? This is one of the pages which will be heavily used by mobile users. Currently there is a large border. Everything else works as expected, nice!

@Plebysnacc Plebysnacc mentioned this pull request Apr 17, 2025
Open
@Plebysnacc Plebysnacc requested a review from dheidemann April 17, 2025 21:16
@Plebysnacc Plebysnacc mentioned this pull request Apr 17, 2025
Closed
@Plebysnacc Plebysnacc linked an issue Apr 17, 2025 that may be closed by this pull request
Add Notification for Successful Registrations #65
Closed
@Plebysnacc Plebysnacc moved this from Todo to Waiting in pepp Apr 18, 2025
dheidemann
dheidemann approved these changes Apr 24, 2025
View reviewed changes
Copy link
Member

@dheidemann dheidemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, lgtm

@Plebysnacc Plebysnacc merged commit a21abce into main Apr 24, 2025
2 checks passed
@Plebysnacc Plebysnacc deleted the 85-page-tutor-registration-form branch April 24, 2025 11:23
@github-project-automation github-project-automation bot moved this from Waiting to Done in pepp Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dheidemann dheidemann dheidemann approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request frontend
Projects
pepp
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Page: Tutor registration form Add Notification for Successful Registrations
2 participants
@Plebysnacc @dheidemann