Corregir manejo de booleanos en PostgreSQL en ReportTaxes#80
Merged
NeoRazorX merged 1 commit intoFacturaScripts:mainfrom Apr 7, 2026
Merged
Conversation
PostgreSQL returns boolean values as the strings "t"/"f" instead of 1/0 (as MySQL does). In PHP, the string "f" is truthy, so the condition `$row['suplido'] ? 0 : $pvpTotal` incorrectly evaluates to 0 for all non-suplido lines, causing the tax report to calculate a net total of 0. Use filter_var with FILTER_VALIDATE_BOOLEAN to properly convert the database value to a PHP boolean regardless of the database backend.
DanielRamosAcosta
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resumen
"t"/"f"en vez de1/0(como hace MySQL)"f"es truthy, por lo que$row['suplido'] ? 0 : $pvpTotalevalúa incorrectamente a0para todas las líneas que no son suplidosfilter_var($row['suplido'], FILTER_VALIDATE_BOOLEAN)para convertir correctamente el valor independientemente del motor de base de datosPlan de pruebas
0/1)