-
Notifications
You must be signed in to change notification settings - Fork 45
#314 Fixes: Added multi-architecture Docker build support with uv dependency management #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f8004bf
updated dockerfile for multiarch image support
RaghuveeRR07 6d69c83
Merge branch 'exospherehost:main' into main
RaghuveeRR07 35a1747
Merge branch 'exospherehost:main' into main
RaghuveeRR07 7aeac51
Updated dockerfile to support multiarch
RaghuveeRR07 ade1704
updated dockerfile after implementing suggestions
RaghuveeRR07 543eebc
updated dockerfile to use version ARG
RaghuveeRR07 8d2935c
updated dockerfile to use digest
RaghuveeRR07 c822687
updated dockerfile to use manifest digest
RaghuveeRR07 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RaghuveeRR07 I do not understand why the earlier implementation was not working but current one is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please explain more ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The earlier implementation had the latest tag due to which the manifest files for some architecture like armv7 did not exist. this was one of the error I encountered buildx error: “no match for platform in manifest”.
Manifest file is a just a JSON file, which has info about which image is suitable for which arch.
This is the only change I implemented because when I even tried pushing the image of docker hub, armv7 failed. So I understood there is need to specify the version while installing uv.
All the other changes were suggested by this codeReview bot, so I am not really sure what the "digest" tag does.