Fix price history query amplification - #15
Merged
NateIsern merged 1 commit intoJun 25, 2026
Conversation
NateIsern
deleted the
codex/fix-price-history-api-availability-vulnerability
branch
June 25, 2026 19:18
NateIsern
added a commit
that referenced
this pull request
Jun 25, 2026
Document the merged hardening PRs and bump version: - restrict trusted proxy headers via TRUSTED_PROXY_CIDRS (#16) - redact public peer topology from /api/peers (#17) - single bounded price-history query (no findOne fan-out) (#15) Also note the TRUSTED_PROXY_CIDRS deployment requirement in the README. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
findOnelookups, which can saturate a small MongoDB connection pool and cause availability issues on the public/api/price/historyendpoint.7d) once the sampled series exceededHISTORY_MAX_POINTS, making the amplification the common case rather than an edge case.Description
findOnefanout with a single sortedPricePoint.find({ timestamp: { $gte: cutoff } })query and in-memory processing to thin the series.docsand selects nearest documents for each evenly spaced target time, then ensures the newest point is retained; this preserves theHISTORY_MAX_POINTS-bounded, oldest→newest output.server/routes/price.tsin thefetchBoundedPriceHistoryhelper, removing thePromise.allmulti-query approach and keeping external behavior and response shape unchanged.Testing
npm run typecheck, which completed successfully.npm test(Vitest), and all tests passed (4 files, 42 tests).npm test -- --runInBandwhich failed because Vitest does not accept Jest-style--runInBandoptions (this is a test runner option mismatch, not a functional regression).Codex Task