fix(server): restrict trusted proxy headers - #16
Merged
Conversation
NateIsern
force-pushed
the
codex/fix-x-forwarded-for-rate-limit-bypass
branch
from
June 25, 2026 19:19
36c9af3 to
f92d7b0
Compare
NateIsern
added a commit
that referenced
this pull request
Jun 25, 2026
Document the merged hardening PRs and bump version: - restrict trusted proxy headers via TRUSTED_PROXY_CIDRS (#16) - redact public peer topology from /api/peers (#17) - single bounded price-history query (no findOne fan-out) (#15) Also note the TRUSTED_PROXY_CIDRS deployment requirement in the README. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
NateIsern
added a commit
that referenced
this pull request
Jun 25, 2026
Document the merged hardening PRs and bump version: - sanitize /api/validate-address response + input (#18) - limit /api/network-info to public fields (#19) - cap WebSocket frame size via maxPayload (#20) Note: #20's TCP-peer WS-IP change was dropped on merge (would break the per-IP WS cap behind the proxy); #16's trusted-proxy resolution is kept. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
trust proxy, allowing direct clients to spoofX-Forwarded-Forand evade per-IP HTTP and WebSocket rate limits.Description
trust proxy = 1with an explicitTRUSTED_PROXY_CIDRSallowlist parsed fromprocess.env.TRUSTED_PROXY_CIDRSand used as the Express trust predicate viaapp.set('trust proxy', isTrustedProxy).TRUSTED_PROXY_RANGESand theisTrustedProxycheck.resolveClientIpto consult the sameisTrustedProxypolicy and ignoreX-Forwarded-Forunless the TCP peer is a trusted proxy.TRUSTED_PROXY_CIDRSsetting in.env.exampleand add the necessarynetimport inserver/index.ts.Testing
npx tsc -p server/tsconfig.json --noEmit, which completed successfully.npm test, which completed successfully (all tests passed).npm test -- --runInBandinvocation failed because Vitest does not accept the Jest--runInBandflag, but the suite was re-run withnpm testand passed.Codex Task