Redact public peers API topology details - #17
Merged
Conversation
NateIsern
added a commit
that referenced
this pull request
Jun 25, 2026
Document the merged hardening PRs and bump version: - restrict trusted proxy headers via TRUSTED_PROXY_CIDRS (#16) - redact public peer topology from /api/peers (#17) - single bounded price-history query (no findOne fan-out) (#15) Also note the TRUSTED_PROXY_CIDRS deployment requirement in the README. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
/api/peersendpoint returned rawgetpeerinfooutput (addresses, client strings, timing, byte counts, ban score, sync state), which exposes the node's live network topology and private peers.Description
/api/peersroute inserver/index.tsto redact sensitive per-peer details by replacing rawaddrwith stable placeholder labels and zeroing or blanking client/timing/traffic/sync fields while preserving theinboundboolean and the JSON response shape expected by the UI.Testing
bun run typecheckwhich completed successfully, and ranbun testwhich executed the test suite but reported unrelated frontendi18ntest failures due tolocalStoragebeing undefined in the current test environment (server-side tests ran and the change did not introduce new server failures).Codex Task