fix(api): limit recent transaction feed fan-out - #24
Open
NateIsern wants to merge 1 commit into
Open
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
/api/transactionsfeed by re-applying stricter rate limiting and avoiding per-item parent-transaction enrichment.enrichInputPrevoutsfan-out.Description
strictLimitermiddleware to the plural route by registeringapp.use('/api/transactions', strictLimiter, transactionsRouter)inserver/index.tsso the feed is protected by the same strict cap as other expensive RPC-backed endpoints.prevoutLookupBudgetand passing it toblockCache.getTransaction(..., { prevoutLookupBudget })inserver/routes/transactions.tsso onlyvouttotals are used.server/index.tsandserver/routes/transactions.ts.Testing
bun --bun run typecheck, which completed successfully.bun --bun run test, where 24 tests passed but the run failed due to environment/tooling issues (az.enumimport error inserver/lib/http.test.tsand ajsdom/worker startup error), so no project-test regressions related to these changes were observed in the passing tests.Codex Task