fix: throttle transactions feed - #25
Open
NateIsern wants to merge 1 commit into
Open
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
/api/transactionsfeed performs expensive daemon RPC fan-out (defaultgetrawmempool+ up to 20getmempoolentrycalls) but was only covered by the permissive global limiter, allowing unauthenticated clients to generate large backend load; this change bounds per-IP request cost.Description
strictLimiterto the/api/transactionsroute inserver/index.tsso the feed is protected the same way as other expensive RPC-backed endpoints.Testing
npm testwhich completed successfully (all test files passed).npm run typecheckwhich succeeded.npm test -- --runInBandwhich failed because Vitest does not support the--runInBandflag, andgit diff --checkreturned clean results.Codex Task