feat(i18n): expand Explorer to 17 languages (incl. Catalan) and RTL support - #26
Merged
Merged
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
ca,hi,ar,bn,pt,id,ur,tr, andviand theirsrc/messages/*.jsonfiles and integrating them intosrc/lib/i18n.ts.Localetype,SUPPORTED_LOCALESlist, andmessagesByLocalemap, and added automatic documentlang/dirsynchronization with RTL detection for Arabic and Urdu via asyncDocumentLanguagehelper.useTranslations('common')insrc/components/language-selector.tsxso feedback uses the active locale's template instead of a fixed English string.RelativeTimeandGithubCardto include the new locales and remapped Urdu to use Arabic date locale where appropriate so relative-time formatting follows the active locale.src/lib/i18n.test.tswith assertions that at least 15 languages are available (including Catalan) and that RTL direction is applied for Arabic/Urdu.Testing
npm test -- --run src/lib/i18n.test.tsand all tests passed (11 tests passing).npm run typecheck(TypeScript project build) and it completed successfully.npm run build(Vite) and the build completed successfully.Codex Task