Secure genesis miner temporary files - #17
Open
NateIsern wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
genesis-mine.shpreviously wrote and sourced predictable files under/tmpwhich allowed local race/pre-creation attacks to inject shell code.sudoto install packages before sourcing the results file, increasing impact if an attacker can cause code execution by priming sudo credentials.Description
/tmpartifacts with a private temporary directory created bymktemp -dassigned toGENESIS_TMPDIRand restricted withchmod 700so only the script owner can access generated files.GENESIS_MINERand the results path asGENESIS_RESULTS, write the Python miner intoGENESIS_MINER, and update it to write results toGENESIS_RESULTSviaos.environ.python3 "$GENESIS_MINER"andsourceonly the private"$GENESIS_RESULTS"file, and add anEXITtrapcleanup_genesis_tmp()to remove the temporary directory on exit.Testing
bash -n genesis-mine.shto validate shell syntax and it succeeded.git diff --checkto verify no leftover whitespace or conflict markers and it succeeded.shellcheck genesis-mine.shbutshellcheckis not installed in the environment so it was not executed.Codex Task