feat: add progress bar to CLI #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested: - Ran clean install, saw progress bar and no artifacts, and after OD completed, could interact with terminal again
Collaborator
|
Any thoughts on avoiding curses? https://stackoverflow.com/questions/3173320/text-progress-bar-in-terminal-with-block-characters |
Collaborator
|
This needs the fixes found in #379. Please rebase on latest main for testing. |
Contributor
Author
Found some other articles as well, and after removing an unused feature I added, curses isn't needed |
thw26
requested changes
Mar 11, 2025
Collaborator
thw26
left a comment
thw26
left a comment
There was a problem hiding this comment.
I got this when downloading. Can we either overwrite the Downloading… line or can we tell the program to print only if the message is different?
Downloading wine-stable_10.0-x86_64.AppImage…
Downloading wine-stable_10.0-x86_64.AppImage…
Downloading wine-stable_10.0-x86_64.AppImage…
Downloading wine-stable_10.0-x86_64.AppImage…
Downloading wine-stable_10.0-x86_64.AppImage…
Downloading wine-stable_10.0-x86_64.AppImage…
Downloading wine-stable_10.0-x86_64.AppImage…
Downloading wine-stable_10.0-x86_64.AppImage…
Downloading wine-stable_10.0-x86_64.AppImage…
Downloading wine-stable_10.0-x86_64.AppImage…
Downloading wine-stable_10.0-x86_64.AppImage…
Downloading wine-stable_10.0-x86_64.AppImage…
Downloading wine-stable_10.0-x86_64.AppImage…
Downloading wine-stable_10.0-x86_64.AppImage…
Downloading wine-stable_10.0-x86_64.AppImage…
Downloading wine-stable_10.0-x86_64.AppImage…
Downloading wine-stable_10.0-x86_64.AppImage…
Downloading wine-stable_10.0-x86_64.AppImage…
Downloading wine-stable_10.0-x86_64.AppImage…
Downloading wine-stable_10.0-x86_64.AppImage…
Downloading wine-stable_10.0-x86_64.AppImage…
Downloading wine-stable_10.0-x86_64.AppImage…
Downloading wine-stable_10.0-x86_64.AppImage…
Verifying /home/thwright/.cache/FaithLife-Community/wine-stable_10.0-x86_64.AppImage…
Contributor
Author
Woops that check was in there at some point, added back. Tested:
|
thw26
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be noted this restricts the CLI to only working on *NIX system - as it uses curses
Tested: