Skip to content

test: expand integration test #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

ctrlaltf24
Copy link
Contributor

@ctrlaltf24 ctrlaltf24 commented Mar 9, 2025

Now the integration test:

  • Tests clean install
  • Tests first time resource download
  • Tests the free tools/guides to ensure they don't crash
  • ensures crash detection logic works (with a test!)

Lots of room to expand this, and obvious integrate into unittest somehow (we'll need to be able to filter these tests separately as their design goals is different). These tests are designed for: Does OD install Logos in such a way that it doesn't crash when doing normal tasks? While unittest is designed for: does the python do what we expect it to do?

This file should also be broken up when it's integrated, kept as one file for now, but it will be split.

also increase robustness
Framework laid down here will be able to be re-used as this test suite expands

Tested:
- ran, pass
@ctrlaltf24 ctrlaltf24 requested review from thw26 and n8marti March 10, 2025 15:31
Haven't been able to determine why sometimes a : is types as a ;, however tests still "pass" as we can only check to see if the software crashed - we can't do much about seeing if the feature worked.

In the future we should consider adding a screenshot function to at least for a record of what actually happened
@ctrlaltf24
Copy link
Contributor Author

Going to switch gears now and work on a follow-on PR to integrate this into CI.

This can merge-as is (so you guys can use it to test other PRs in the meantime)

Copy link
Collaborator

@n8marti n8marti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Good, thorough, start on testing most basic functionality. Only a couple of requests to fix typos.

Do you think it would be possible to implement this in a GH action (down the road, not necessarily now)? As in, use something like ubuntu-latest, then install a desktop environment, then run the tests?

@ctrlaltf24
Copy link
Contributor Author

Yup that's the goal! That's considerably harder than expanding this, so made it into two separate PRs. I'll also need to add backup/restore tests, as well screenshot functionality, as well as triggers for the full integration test dream

@ctrlaltf24 ctrlaltf24 requested a review from n8marti April 10, 2025 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants