-
Notifications
You must be signed in to change notification settings - Fork 13
test: expand integration test #372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
test: expand integration test #372
Conversation
also increase robustness
Framework laid down here will be able to be re-used as this test suite expands Tested: - ran, pass
Haven't been able to determine why sometimes a : is types as a ;, however tests still "pass" as we can only check to see if the software crashed - we can't do much about seeing if the feature worked. In the future we should consider adding a screenshot function to at least for a record of what actually happened
Going to switch gears now and work on a follow-on PR to integrate this into CI. This can merge-as is (so you guys can use it to test other PRs in the meantime) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Good, thorough, start on testing most basic functionality. Only a couple of requests to fix typos.
Do you think it would be possible to implement this in a GH action (down the road, not necessarily now)? As in, use something like ubuntu-latest, then install a desktop environment, then run the tests?
Yup that's the goal! That's considerably harder than expanding this, so made it into two separate PRs. I'll also need to add backup/restore tests, as well screenshot functionality, as well as triggers for the full integration test dream |
Now the integration test:
Lots of room to expand this, and obvious integrate into unittest somehow (we'll need to be able to filter these tests separately as their design goals is different). These tests are designed for: Does OD install Logos in such a way that it doesn't crash when doing normal tasks? While unittest is designed for: does the python do what we expect it to do?
This file should also be broken up when it's integrated, kept as one file for now, but it will be split.