fix: wine logging #378
Merged
fix: wine logging #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logos/Verbum (Indexer) now log to the wine log file, with their previous run logging to wine.1.log All other wine executions as part of the install process now go into OD's log Fixes: FaithLife-Community#376 Tested: - run logos, log is in wine.log, launching a second time, it's moved to wine.1.log, and the new one is at wine.log - clean install (confirm log is expected) - during install msi TRANSFORMS functions, and msiexec logs are in OD's - winetricks logs during install are in OD's - during install winemenubuilder/renderer/fontsmoothing logs are in OD's - TUI set windows version - switch Logos logging wine execution goes into OD's log (looks to be empty) - install fonts detects existing arial font - ran indexing (confirm log as expected) - winetricks command, make sure stdout/stderr/exitcode are passed correctly (didn't confirm stdin, don't know what takes this. Fortunately code is the same for wine, and it worked.) - wine command, make sure stdout/stderr/stdin are passed correctly
Collaborator
|
I merged #379 as its fixes were needed to make this PR run on my end. Please re-push this branch after rebasing onto latest main, after which I will rest. |
thw26
approved these changes
Mar 11, 2025
Collaborator
|
Good to go, but it again has conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logos/Verbum (Indexer) now log to the wine log file, with their previous run logging to wine.1.log
All other wine executions as part of the install process now go into OD's log
Fixes: #376
Tested: