feat: support Stop app operation on GUI #384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TUI already has this behavior Tested (40.2 clean install pre-login): - Started OD with app installed, but not running -> Run Logos shown - When "Run Logos" is hit, button switches to "Stop Logos" - When Logos was launched using OD, but is closed independently of OD, button switches to "Run Logos" after the app closes - "Run App" -> Switches to "Stop App", when "Stop App" is clicked, it stops Logos and switches to "Run Logos", when "Run Logos" is hit again, it launches - GUI when Logos isn't installed no errors seen on console - When Logos is installed via the GUI, button switches from "Install" to "Run Logos". Hitting that switches to "Stop Logos", hitting that switches to "Run Logos" which launches Logos
ctrlaltf24
changed the title
n8marti
approved these changes
Mar 19, 2025
Collaborator
n8marti
left a comment
n8marti
left a comment
There was a problem hiding this comment.
Looks good. Merge it in if you feel like you've done sufficient testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TUI already has this behavior
Tested (40.2 clean install pre-login):