-
Notifications
You must be signed in to change notification settings - Fork 17
feat: detect opengl version #389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ou_dedetai/system.py
Outdated
|
|
||
| def get_opengl_version(required_version="3.2"): | ||
| try: | ||
| result = subprocess.run(['glxinfo'], capture_output=True, text=True, check=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not currently using our system.run_command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At very least this needs the LD_LIBRARY_PATH fix. See the invitation of subprocess in wine.py for how to use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Submitting a commit soon that I believe implements this. Will leave open for verification.
ou_dedetai/system.py
Outdated
|
|
||
| def get_opengl_version(required_version="3.2"): | ||
| try: | ||
| result = subprocess.run(['glxinfo'], capture_output=True, text=True, check=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At very least this needs the LD_LIBRARY_PATH fix. See the invitation of subprocess in wine.py for how to use
|
Two main concerns:
|
My suggestion would be let's add a continue question?
This I think is the main issue, even with the continue question. So, given this, the OpenGL check should happen right after package install, no? |
|
I added a new function for all system checks. I think this is cleanest and helps specify these aren't ensure steps as it were. They may be better located under check system dependencies itself. |
Modified this to use a subprocess call rather than using the OpenGL Python libraries. This bypasses the GTK issues described below.
Fixes #366. Adds ability to get OpenGL version, and we compare the retrieved version to the minimum version.
Main test case is a PineTab2, which has a graphics limit of OpenGL 3.1. I'm not actually sure if OpenGL 3.2 is a minimum; it is just a guess based on my current knowledge of the lower limit.
We run this before install in order to prevent wasting the user's time.
We run this whenever we launch Logos to ensure that we can launch, e.g., if the user moves an install to a new computer.
Does some minor work in moving imports around in order to make the program run and to clean up ordering.
TODO