Skip to content

Conversation

@ctrlaltf24
Copy link
Contributor

@ctrlaltf24 ctrlaltf24 commented Aug 29, 2025

Adds support for wine pre-releases

Automatically attempts to detect #435 and switches users who chose "Recommended" to the beta channel, as well as adds a beta option for all users.

Tested:

debian 12 snap firefox

  • install correctly switch to -devel
  • (install failed due to a fuse issue, unrelated)

debian 12 flatpak firefox

  • install correctly switch to -devel
  • (installed failed due to running out of space in VM)

debian 13 Dooble correctly switched to -devel

  • aborted install once text was obsered

debian 13 Opera correctly switched to -devel

  • aborted install once text was obsered

debian 13 Chromium correctly switched to -devel

  • aborted install once text was obsered

debian 13 Qutebrowser correctly switched to -devel

  • aborted install once text was obsered

debian 13 Vivaldi correctly switched to -devel

  • aborted install once text was obsered

debian 13 Brave correctly switched to -devel

  • aborted install once text was obsered

debian 13 Falkon correctly switched to -devel

  • aborted install once text was obsered

debian 13 Google Chrome correctly switched to -devel

  • aborted install once text was obsered

debian 12 Chromium correctly switched to -devel

  • install success
  • logged in
  • got to the "Download your Logos Library page"
  • Downloaded resources
  • Logos launched for first time
  • saw dashboard
  • opened bible
  • opened factbook
  • opened reading plan
  • opened bible passage workflow guide

Debian 12 TUI advanced install

  • choose advanced install and "experimental" wine
  • install success, using wine pre release

Debian 12 GUI advanced install

  • choose advanced install and "experimental" wine
  • install success, using wine pre release

Debian 12 CLI advanced install

  • choose advanced install and "experimental" wine
  • install success, using wine pre release

There is presently a wine bug that makes chromium as a browser not work. Detect and remediate.

Also run update-desktop-database after install. Needed for snaps to pickup the new mime type.
fix: detect FaithLife-Community#435 and suggest changing wine channel.
Should we force this?

chore: updated "Get Support" text to add reminder about checking pinned issues before reporting

refactor: store wine_binary as a sigil rather than a path for part of the installation so we can detect the difference between needing to download something and a file on the system (as well as figure out if the user just wants the recommended and doesn't really care about the details)

refactor: change the API endpoint to get all the releases so that we can get the prerelease ones as well

feat(TUI): add button to toggle wine release channel.
Should this be on other UIs as well, especially if users are forced down this path to avoid issue FaithLife-Community#435? Something doesn't smell right UX wise.
@ctrlaltf24 ctrlaltf24 requested review from n8marti and thw26 August 29, 2025 03:05
@ctrlaltf24 ctrlaltf24 changed the title Fix detect and avoid using chomium while broken feat: support wine beta channel Aug 29, 2025
remove non-linux browsers
fix applications path
handle case where the wine binary is stored as the path rather than the sigil

Tested:
- debian 12 snap firefox
- install correctly switch to -devel
- (install failed due to a fuse issue, unrelated)

- debian 12 flatpak firefox
- install correctly switch to -devel
- (installed failed due to running out of space in VM)

- debian 13 Dooble correctly switched to -devel
- aborted install once text was obsered

- debian 13 Opera correctly switched to -devel
- aborted install once text was obsered

- debian 13 Chromium correctly switched to -devel
- aborted install once text was obsered

- debian 13 Qutebrowser correctly switched to -devel
- aborted install once text was obsered

- debian 13 Vivaldi correctly switched to -devel
- aborted install once text was obsered

- debian 13 Brave correctly switched to -devel
- aborted install once text was obsered

- debian 13 Falkon correctly switched to -devel
- aborted install once text was obsered

- debian 13 Google Chrome correctly switched to -devel
- aborted install once text was obsered

- debian 12 Chromium correctly switched to -devel
- install success
- logged in
- got to the "Download your Logos Library page"
@ctrlaltf24 ctrlaltf24 changed the title feat: support wine beta channel feat: support wine pre releases Sep 1, 2025
@ctrlaltf24 ctrlaltf24 marked this pull request as ready for review September 1, 2025 04:59
Copy link
Collaborator

@thw26 thw26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the code. Now I just need to test.

@ctrlaltf24
Copy link
Contributor Author

ctrlaltf24 commented Sep 7, 2025

Had a user test, worked with a snap browser

I tried to test with a snap browser and got it to launch firefox in a snap, but couldn't get back to OuDedetai (didn't detect the registration, and even if it did unsure if launching OD from INSIDE the snap is the best idea)

Ending confused, do we need to make something more elaborate with DBus messages? Would rather not, this is getting complicated...

The double "click here" buttons still work - it's possible we could add a help text for this

Reproduction:
- install once needing the -devel
- run the install again
- notice how it switched back to -staging

Tested:
- Debian chromium install once (-devel)
- re-ran install (observed -devel)
@thw26 thw26 merged commit c03c14d into FaithLife-Community:main Sep 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants