feat: display login workarounds in a pop up #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure why this didn't pop up earlier in testing, but for some reason it appeared on my machine so added an additional check to make sure the appimage downloads
Detect when the user hasn't logged in after a set period and suggest some workarounds while we're having issues. Tested: - Ran uninstall then install - On a signed in Logos install (but before resource download) confirmed that the dialog wouldn't appear - On a clean install on the CLI waited 5 minutes, prompt to troubleshoot appeared in terminal - On a clean install on the GUI hit "Run Logos" then waited 2 minutes and observed the trouble signing in dialog - On a clean install on the TUI hit "Run Logos" then waited 2 minutes and observed the trouble signing in dialog. - After returning to main menu, confirmed that the dialog didn't show up again for that run
Applies something similar to what was recommended in FaithLife-Community#438 (though this doesn't solve that issue) Tested: - built binary - ran install from binary - ran logos from binary - accomplished sign on - checked desktop in ~/.local/share/applications to ensure it looked right - simulated failure in edited script, echo displays properly.
thw26
requested changes
Oct 14, 2025
| logos_appdata_dir = self.app.conf._logos_appdata_dir | ||
| if logos_appdata_dir is None: | ||
| logging.warning("The user should have installed the Logos application by now and have this populated." | ||
| " Waiting until that is resolved...") |
| if get_logos_user_id(logos_appdata_dir) is not None: | ||
| is_user_logged_in = True | ||
|
|
||
| sent_trouble_singing_in_message: bool = False |
Collaborator
There was a problem hiding this comment.
Correct var name "sent_trouble_singing_in_message" to "sent_trouble_signing_in_message"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the user experience of browser login better by detecting likely failures and recommend solutions. Some problems still linger getting the browser to launch, then getting Logos to get the signal back.
#400
#435
#438