-
Notifications
You must be signed in to change notification settings - Fork 1
Bump version from 0.4.0 to 0.4.1 #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
repbulish with a new FalkorDB version
WalkthroughProject version and FalkorDB reference updates: package metadata version bumped from 0.4.0 to 0.4.1, and FalkorDB default/version variables updated from v4.14.7 to v4.14.9 across CI, publish workflows, and setup script. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/ci.yml(3 hunks).github/workflows/publish.yml(1 hunks)setup.py(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: Test on Python 3.12
- GitHub Check: Test on macOS Python 3.13
- GitHub Check: Test on macOS Python 3.14
- GitHub Check: Test on macOS Python 3.12
- GitHub Check: Test on Python 3.14
- GitHub Check: Test on Python 3.13
| env: | ||
| REDIS_VERSION: '8.2.2' | ||
| FALKORDB_VERSION: 'v4.14.7' | ||
| FALKORDB_VERSION: 'v4.14.9' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical: FalkorDB v4.14.9 does not exist.
According to the GitHub releases page, v4.14.8 is the latest FalkorDB release. Version v4.14.9 does not exist, which will cause the FalkorDB module download to fail during CI execution.
Update the version to v4.14.8:
- FALKORDB_VERSION: 'v4.14.9'
+ FALKORDB_VERSION: 'v4.14.8'Also applies to: 98-98, 181-181
🤖 Prompt for AI Agents
.github/workflows/ci.yml around lines 21, 98 and 181: the CI file references a
non-existent FalkorDB version v4.14.9 which will break downloads; update all
occurrences to the valid release tag v4.14.8 by replacing 'v4.14.9' with
'v4.14.8' in those three lines so the workflow uses the correct existing
release.
| env: | ||
| REDIS_VERSION: '8.2.2' | ||
| FALKORDB_VERSION: 'v4.14.7' | ||
| FALKORDB_VERSION: 'v4.14.9' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical: FalkorDB v4.14.9 does not exist.
According to the GitHub releases page, v4.14.8 is the latest FalkorDB release. Version v4.14.9 does not exist, which will cause the publish workflow to fail when building wheels.
Update the version to v4.14.8:
- FALKORDB_VERSION: 'v4.14.9'
+ FALKORDB_VERSION: 'v4.14.8'📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| FALKORDB_VERSION: 'v4.14.9' | |
| FALKORDB_VERSION: 'v4.14.8' |
🤖 Prompt for AI Agents
.github/workflows/publish.yml around line 26: the workflow sets FALKORDB_VERSION
to 'v4.14.9' which does not exist and will break the publish job; change the
value to the latest valid tag 'v4.14.8' so the workflow uses an existing
FalkorDB release (update the YAML value only).
| REDIS_VERSION = os.environ.get('REDIS_VERSION', '8.2.2') | ||
| REDIS_URL = f'http://download.redis.io/releases/redis-{REDIS_VERSION}.tar.gz' | ||
| FALKORDB_VERSION = os.environ.get('FALKORDB_VERSION', 'v4.14.7') | ||
| FALKORDB_VERSION = os.environ.get('FALKORDB_VERSION', 'v4.14.9') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical: FalkorDB v4.14.9 does not exist.
According to the GitHub releases page, v4.14.8 is the latest FalkorDB release. Version v4.14.9 does not exist, which will cause the module download at line 97 to fail with a 404 error.
Update the default version to v4.14.8:
-FALKORDB_VERSION = os.environ.get('FALKORDB_VERSION', 'v4.14.9')
+FALKORDB_VERSION = os.environ.get('FALKORDB_VERSION', 'v4.14.8')📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| FALKORDB_VERSION = os.environ.get('FALKORDB_VERSION', 'v4.14.9') | |
| FALKORDB_VERSION = os.environ.get('FALKORDB_VERSION', 'v4.14.8') |
🤖 Prompt for AI Agents
In setup.py around line 39, the default FALKORDB_VERSION is set to 'v4.14.9'
which does not exist and will cause downloads to 404; change the default to
'v4.14.8' (the latest released tag) by updating the environment fallback value
so os.environ.get('FALKORDB_VERSION', 'v4.14.8') is used, ensuring any existing
env override still works.
repbulish with a new FalkorDB version
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.