Skip to content

Conversation

@gkorland
Copy link

@gkorland gkorland commented Dec 14, 2025

repbulish with a new FalkorDB version

Summary by CodeRabbit

  • Chores
    • Bumped package patch version to 0.4.1.
    • Updated the bundled FalkorDB component used for builds and workflows to a newer maintenance release (v4.14.9).

✏️ Tip: You can customize this high-level summary in your review settings.

repbulish with a new FalkorDB version
@coderabbitai
Copy link

coderabbitai bot commented Dec 14, 2025

Walkthrough

Project version and FalkorDB reference updates: package metadata version bumped from 0.4.0 to 0.4.1, and FalkorDB default/version variables updated from v4.14.7 to v4.14.9 across CI, publish workflows, and setup script.

Changes

Cohort / File(s) Summary
Package metadata
setup.cfg
[metadata] version changed from 0.4.00.4.1.
CI & publish workflows
.github/workflows/ci.yml, .github/workflows/publish.yml
FALKORDB_VERSION environment variable changed from v4.14.7v4.14.9 in relevant jobs.
Build/install script
setup.py
Module-level FALKORDB_VERSION default changed from 'v4.14.7''v4.14.9'.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Pay attention to consistency between workflow env vars and setup.py default.
  • Verify any release artifacts or packaging steps that depend on the FalkorDB version.

Poem

🐰 A tiny hop, a tiny cheer,
A version nudged, the path is clear.
From four-point-zero to four-point-one,
And FalkorDB's bright new sun —
I nibble bugs and dance in fun 🌿

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Bump version from 0.4.0 to 0.4.1' accurately describes the main change in setup.cfg. However, the PR also updates FalkorDB versions in multiple workflow and setup files, which is a significant part of the changeset not captured in the title.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch gkorland-patch-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between da37711 and ff1fbe6.

📒 Files selected for processing (3)
  • .github/workflows/ci.yml (3 hunks)
  • .github/workflows/publish.yml (1 hunks)
  • setup.py (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: Test on Python 3.12
  • GitHub Check: Test on macOS Python 3.13
  • GitHub Check: Test on macOS Python 3.14
  • GitHub Check: Test on macOS Python 3.12
  • GitHub Check: Test on Python 3.14
  • GitHub Check: Test on Python 3.13

env:
REDIS_VERSION: '8.2.2'
FALKORDB_VERSION: 'v4.14.7'
FALKORDB_VERSION: 'v4.14.9'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Critical: FalkorDB v4.14.9 does not exist.

According to the GitHub releases page, v4.14.8 is the latest FalkorDB release. Version v4.14.9 does not exist, which will cause the FalkorDB module download to fail during CI execution.

Update the version to v4.14.8:

-      FALKORDB_VERSION: 'v4.14.9'
+      FALKORDB_VERSION: 'v4.14.8'

Also applies to: 98-98, 181-181

🤖 Prompt for AI Agents
.github/workflows/ci.yml around lines 21, 98 and 181: the CI file references a
non-existent FalkorDB version v4.14.9 which will break downloads; update all
occurrences to the valid release tag v4.14.8 by replacing 'v4.14.9' with
'v4.14.8' in those three lines so the workflow uses the correct existing
release.

env:
REDIS_VERSION: '8.2.2'
FALKORDB_VERSION: 'v4.14.7'
FALKORDB_VERSION: 'v4.14.9'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Critical: FalkorDB v4.14.9 does not exist.

According to the GitHub releases page, v4.14.8 is the latest FalkorDB release. Version v4.14.9 does not exist, which will cause the publish workflow to fail when building wheels.

Update the version to v4.14.8:

-      FALKORDB_VERSION: 'v4.14.9'
+      FALKORDB_VERSION: 'v4.14.8'
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
FALKORDB_VERSION: 'v4.14.9'
FALKORDB_VERSION: 'v4.14.8'
🤖 Prompt for AI Agents
.github/workflows/publish.yml around line 26: the workflow sets FALKORDB_VERSION
to 'v4.14.9' which does not exist and will break the publish job; change the
value to the latest valid tag 'v4.14.8' so the workflow uses an existing
FalkorDB release (update the YAML value only).

REDIS_VERSION = os.environ.get('REDIS_VERSION', '8.2.2')
REDIS_URL = f'http://download.redis.io/releases/redis-{REDIS_VERSION}.tar.gz'
FALKORDB_VERSION = os.environ.get('FALKORDB_VERSION', 'v4.14.7')
FALKORDB_VERSION = os.environ.get('FALKORDB_VERSION', 'v4.14.9')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Critical: FalkorDB v4.14.9 does not exist.

According to the GitHub releases page, v4.14.8 is the latest FalkorDB release. Version v4.14.9 does not exist, which will cause the module download at line 97 to fail with a 404 error.

Update the default version to v4.14.8:

-FALKORDB_VERSION = os.environ.get('FALKORDB_VERSION', 'v4.14.9')
+FALKORDB_VERSION = os.environ.get('FALKORDB_VERSION', 'v4.14.8')
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
FALKORDB_VERSION = os.environ.get('FALKORDB_VERSION', 'v4.14.9')
FALKORDB_VERSION = os.environ.get('FALKORDB_VERSION', 'v4.14.8')
🤖 Prompt for AI Agents
In setup.py around line 39, the default FALKORDB_VERSION is set to 'v4.14.9'
which does not exist and will cause downloads to 404; change the default to
'v4.14.8' (the latest released tag) by updating the environment fallback value
so os.environ.get('FALKORDB_VERSION', 'v4.14.8') is used, ensuring any existing
env override still works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants