-
Notifications
You must be signed in to change notification settings - Fork 4
Add GEDCOM Evidence Extension v2.0 #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Complete redesign to comply with GEDCOM 7 constraints, using a dual-pattern approach: 1. Shadow Records Pattern - Evidence as independent records (_EVID) that can be referenced by multiple individuals through _EVREF 2. Event Container Pattern - Evidence directly tied to an individual through _EVEN_EVID Key features: - Eliminates polymorphic pointers by using separate _SUBJ_INDI, _SUBJ_FAM, and _SUBJ_SOUR structures - Supports floating evidence for uncertain identities - Preserves source information exactly as found - Tracks confidence levels and analysis - Documents research process per Genealogical Proof Standard All structures validated against GEDCOM registry schema. Specification: https://github.com/glamberson/gedcom-evidence Contact: Greg Lamberson <[email protected]>
enumeration/extension/enum-High.yaml
Outdated
|
|
||
| uri: https://github.com/glamberson/gedcom-evidence/enum-High | ||
|
|
||
| extension tags: [ _HIGH ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| extension tags: [ _HIGH ] | |
| extension tags: | |
| - _HIGH |
Luther commented on my PR:
The format description's style guide says
Sequences and mappings should be in the block style unless they are empty, in which case a flow style should be used instead.
This same change would apply in many other places in this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Dave,
I'm fixing these now. Sorry, about the contuing trouble. However, it is extremely challenging to find the correct information to do this. The format description style guide link you provide, for example, is maddeningly difficult to find. I still don't know how to get to it, so I'm glad you provided the link. Going to gedcom.io and trying to find anything is frankly very difficult. Please consider this and make a clear set of instructions with well organized documentation, especially on gedcom.io. Just look at the URL. The first sublevel is TERMS. What on earth is that, and where is the navigation to that on gedcom.io? I can't find it or decipher it.
Thanks!
Changed all flow-style arrays [ item ] to block style as required:
extension tags:
- _TAG
This addresses Dave Thaler's review comment on PR FamilySearch#186 citing the GEDCOM
format style guide requirement that 'Sequences and mappings should be in
the block style unless they are empty.'
Fixed 14 YAML files across enumeration and structure directories.
- Reset registry_tools/GEDCOM.io submodule to match upstream main branch
|
I reset this one also. |
dthaler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently the YAML files contain no used by label. That's fine if this is an unimplemented proposal. If, on the other hand, it is being implemented in something (e.g., gramps), then add a used by label when it actually appears in GEDCOM files used by that app.
| specification: | ||
| - Confidence levels | ||
| - Set of confidence levels for evidence assessment | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommend adding this to files in this PR:
documentation:
- https://github.com/glamberson/gedcom-evidence
| specification: | ||
| - Document Type | ||
| - | | ||
| Specifies the type of document or record that contains the evidence. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the _DTYPE structure used for that can't be obtained from the SOUR structure in parallel to it? I couldn't find the answer at https://github.com/glamberson/gedcom-evidence but may have missed it.
Summary
This PR introduces the GEDCOM Evidence Extension v2.0, a complete redesign to comply with GEDCOM 7 constraints while providing comprehensive evidence handling capabilities.
Background
The previous version (v0.1) in PR #178 was closed due to GEDCOM rule violations including polymorphic pointers and circular dependencies. This v2.0 redesign addresses all those issues using a dual-pattern approach.
Design Approach
The extension uses two complementary patterns:
Pattern 1: Shadow Records
_EVID)_EVREFPattern 2: Event Containers
_EVEN_EVIDKey Structures
Example Usage
Compliance
Documentation
Validation
All 16 YAML files pass validation:
Contact: Greg Lamberson [email protected]