Simplified menu item annotations. - #1110
Merged
alabuzhev merged 1 commit intoJun 13, 2026
Merged
Conversation
MKadaner
force-pushed
the
mzk/simplify-menu-item-Annotations
branch
from
June 9, 2026 01:53
39605af to
88dd223
Compare
alabuzhev
approved these changes
Jun 10, 2026
MKadaner
force-pushed
the
mzk/simplify-menu-item-Annotations
branch
from
June 13, 2026 13:54
88dd223 to
d76a8a8
Compare
|
Contributor
|
Thank you |
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Even though we can render multiple annotations on each
VMenuitem, we never set more than one. So why pretending? Let's be honest and say there can be no more than one. This assumption allows to simplify the code and opens opportunity for further improvements (stay tuned).Checklist
If not checked, I accept that this work might be rejected in favor of a different great big ineffable plan.
Details
menu_item_exwith the single optional annotation.markup_highlight(formermarkup_slice_boundaries) returnsstd::array<string_view, 3>.FixedColumnsAreaandTextAreaofmenu_layoutfromsmall_segmenttosegment.