Clarified DecorateItemsWithHotkeys.

[MKadaner]

Summary

Now getting DecorateItemsWithHotkeys right... Hopefully.

The original implementation would misalign accelerator key of the item "&1&2&3".

References

N/A

Checklist

• I have followed the contributing guidelines.
• I have discussed this with project maintainers: N/A
  
  If not checked, I accept that this work might be rejected in favor of a different great big ineffable plan.
  

Details

Fullwidth-aware DecorateItemsWithHotkeys

DecorateItemsWithHotkeys (former AddHotkeys) tried to compensate the visual string length accounted for by fit_to_left by comparing the results of HiStrlen and visual_string_length. If these functions produce different results, then there is an ampersand in the item name which will be removed during rendering, so we compensated for it adding an extra space before the accelerator string. Unfortunately, escaping ampersand removes all (unescaped) ampersands, so the string may occupy even less screen cells than the algorithm assumed.

The fix is simple: let's assume that HiStrlen returns honest visual length of the properly escaped string. Now, we need to append as many spaces as required to pad the visual length up to the maximum visual length.

Refactoring

1. Renamed menu_item to menu_item_data and decoupled it from menu_item_ex.
   • The similarity between these classes is incidental: menu_item_data is a struct holding data required to construct menu items, while menu_item_ex is the actual non-trivial class representing menu items internally (well, mostly internally).
   • Having cached VisualLength in menu_item_ex enables future optimizations.
   • Removed GetName / SetName from menu_item_data. It is not needed there. I apologize for code churn.
2. Regularized SetCheck, SetCustomCheck, SetSelect, SetDisable, and SetGrayed helpers.
   • Now they are free functions, use a common helper, and serve both menu_item_data and menu_item_ex.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[alabuzhev]

Thank you

[MKadaner]

Thank you!