Skip to content

Fix Windows and Ubuntu CI #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 56 commits into from
Apr 20, 2025
Merged

Fix Windows and Ubuntu CI #601

merged 56 commits into from
Apr 20, 2025

Conversation

pseudo-rnd-thoughts
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts commented Apr 3, 2025 •
edited
Loading

In #599 and #600, the CI is failing for seemingly unrelated reasons to the PRs.
This PR makes no changes to the main to test if the CI passed or failed to help inform the other PRs.

Edit: Yes, the CI is failing on its own :( pain

Changes:

  • Update license to fit setuptool > 77.0
  • Update MACOSX_DEPLOYMENT_TARGET to 13.0 from 10.15
  • Update builtin-baseline to latest (fixes the windows problem)
  • Add glibc-static for ubuntu

@pseudo-rnd-thoughts pseudo-rnd-thoughts changed the title Trigger Build Check Ubuntu CI Apr 3, 2025
@pseudo-rnd-thoughts pseudo-rnd-thoughts changed the title Check Ubuntu CI Check CI Apr 3, 2025
@pseudo-rnd-thoughts pseudo-rnd-thoughts changed the title Check CI Fix Windows and Ubuntu CI Apr 3, 2025
@pseudo-rnd-thoughts
Update ubuntu build wheels dockerfile vcpkg version and remove sdl2 v…
53be1da 
…ersion override
@pseudo-rnd-thoughts
Remove trailing comma
078b7d4
@pseudo-rnd-thoughts
Re-add sdl2 with new version, add dbus-devel to ubuntu install and ca…
565c2a0 
…t log file
@pseudo-rnd-thoughts
Specify the sdl2 features
dce1608
@pseudo-rnd-thoughts
Revert the sdl2 version to 2.30.11
123abef
@pseudo-rnd-thoughts
Remove docker vcpkg install linux
fbc8ee4
@pseudo-rnd-thoughts
Revert docker build for linux
a179be5
@pseudo-rnd-thoughts
Add ninja to build requirements
5296e09
@pseudo-rnd-thoughts
Revert changes and update cibuildwheel to 2.23.2
5507da8
@pseudo-rnd-thoughts
Change zlib version to 1.2.13
1d71590
@pseudo-rnd-thoughts
Add ninja install to linux dockerfile
3c165fb
@pseudo-rnd-thoughts
Remove extra backslash
6e6e274
@pseudo-rnd-thoughts
Add debugging
70dcb5f
@pseudo-rnd-thoughts
Remove CI debugging and add cmake make program
94ef3ce
@pseudo-rnd-thoughts
Remove the ninja support
4cddfd1
@pseudo-rnd-thoughts
Update ninja support
3f051aa
@pseudo-rnd-thoughts
Comment out ninja support in setup.py
d99d4ff
@pseudo-rnd-thoughts
Revert setup.py and change the dockerfile vcpkg to the ubuntu-latest sha
6634114
@pseudo-rnd-thoughts
Update debugging
36bdb92
@pseudo-rnd-thoughts
Add cmake debugging and update dockerfile vcpkg
dce55be
@pseudo-rnd-thoughts
Add logging
c7c63a3
@pseudo-rnd-thoughts
Add custom testing for ubuntu to reproduce the error
58ac217
@pseudo-rnd-thoughts
Add pip install ninja to cibuildwheels
8b29a34
@pseudo-rnd-thoughts
Update setup.py and echo ninja and cmake versions
99d288e
@pseudo-rnd-thoughts
pre-commit
ac99669
@pseudo-rnd-thoughts pseudo-rnd-thoughts mentioned this pull request Apr 6, 2025
Open
@pseudo-rnd-thoughts pseudo-rnd-thoughts mentioned this pull request Apr 20, 2025
Closed
@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit fa48461 into Farama-Foundation:master Apr 20, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pseudo-rnd-thoughts