Skip to content

Add gymnasium_robotics notifications Adroid Hand Warning#8

Merged
pseudo-rnd-thoughts merged 6 commits intoFarama-Foundation:mainfrom
Kallinteris-Andreas:main
Apr 23, 2026
Merged

Add gymnasium_robotics notifications Adroid Hand Warning#8
pseudo-rnd-thoughts merged 6 commits intoFarama-Foundation:mainfrom
Kallinteris-Andreas:main

Conversation

@Kallinteris-Andreas
Copy link
Copy Markdown
Contributor

@Kallinteris-Andreas Kallinteris-Andreas commented Apr 21, 2026

Generate a warning for Farama-Foundation/Gymnasium-Robotics#220

note, I have no idea if the tests are what we are looking for, I have only worked with pytest in Farama projects, also I am not sure how we test without installing multiple version of the packages

@pseudo-rnd-thoughts

Copy link
Copy Markdown
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary? Can't we include this in the documentation, release notes and just change the version number? We don't make these sorts of notifications for Gymnasium when a version is changed for a bug

@Kallinteris-Andreas
Copy link
Copy Markdown
Contributor Author

Kallinteris-Andreas commented Apr 21, 2026

This may be different because the bug was introduced without a version,

The AndroidHandDense-v1 Environments Have a different reward function when using gymnasium-robotics==1.2.0 and gymnasium-robotics>=1.2.1

If it is the FARAMA policy is that when a bug is introduced in the same environment version on a different library release, Then no notifications should be generated.

I am not aware of another case where the The behavior of an environment was changed without a version bump.

Copy link
Copy Markdown
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh I had forgotten that this was due to a package version change without an environment version change so yes this is the correct solution.

Also I've fixed the CI if you merge with main

Comment thread farama_notifications/__init__.py Outdated
@Kallinteris-Andreas
Copy link
Copy Markdown
Contributor Author

test passes on my end

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 501c657 into Farama-Foundation:main Apr 23, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants