Fixup for 'Training An Agent' page#1281
Merged
pseudo-rnd-thoughts merged 3 commits intoFarama-Foundation:mainfrom Jan 6, 2025
Merged
Fixup for 'Training An Agent' page#1281pseudo-rnd-thoughts merged 3 commits intoFarama-Foundation:mainfrom
pseudo-rnd-thoughts merged 3 commits intoFarama-Foundation:mainfrom
Conversation
Member
pseudo-rnd-thoughts
left a comment
There was a problem hiding this comment.
Thanks for the PR, sorry for the late review.
Quick question, why is two of them moving average using "valid" and the final one using "same"?
Contributor
Author
|
Yeah, that middle graph is affected by the start and end windows if they aren't full. Centering (by "same" which is what the python code in the BlackJack Tutorial does) produces this For reference: "valid" removes boundary effects. "same" produces the output length equal to max of the bigger of the two arrays. |
pseudo-rnd-thoughts
approved these changes
Jan 6, 2025
Member
pseudo-rnd-thoughts
left a comment
There was a problem hiding this comment.
Ok, I think that makes sense
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
"Training An Agent" code does not match visual outputs. Short term solution is to change visualization code to match outputs. Long-term proposal to change page to be specifically about agent training and let users go to tutorial for black jack, or do away with page entirely. If keeping page, could turn into a 2-arm/n-arm e-greedy bandit.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Screenshots
Checklist:
pre-commitchecks withpre-commit run --all-files(seeCONTRIBUTING.mdinstructions to set it up)