Skip to content

Comments

Add more Highway Enviroments#110

Draft
MaxCunningham19 wants to merge 2 commits intoFarama-Foundation:mainfrom
MaxCunningham19:main
Draft

Add more Highway Enviroments#110
MaxCunningham19 wants to merge 2 commits intoFarama-Foundation:mainfrom
MaxCunningham19:main

Conversation

@MaxCunningham19
Copy link

Purpose

Using these enviroments for experimentation during my masters thesis so were implementing them localy so I decided to try contribute back.

Implemetation

Added the following enviroments:

Merge

For Merge I clipped the high_speed_reward and merging_speed_reward variables since they were consistently going over their bounds by a marginal amount and thought having a strong cuttof would be more idomatic.

Future work

In the following months I may work on the Parking enviroment but I am currently not looking at using it for my thesis and it was not as straightforward to implement as the others.

@LucasAlegre
Copy link
Collaborator

Hi @MaxCunningham19 , thank you for the PR!

Do you have any experimental results to share? It would be nice to see how conflicting the objectives really are and the shape of the Pareto front.

@MaxCunningham19
Copy link
Author

Hey!

Sorry I don't have solid numbers for how conflicting the objectives are or the pareto front.

Across these enviroments the main conflict is between speed and the other objectives. I dont see much conflict in between the non-speed objectives.

@ffelten
Copy link
Collaborator

ffelten commented Oct 25, 2024

Hi, thanks for the PR. I guess Lucas will review the content. Just don't forget to update the documentation website as well (under docs/):

  • generate gifs
  • add each env to misc.md

@LucasAlegre
Copy link
Collaborator

Hey!

Sorry I don't have solid numbers for how conflicting the objectives are or the pareto front.

Across these enviroments the main conflict is between speed and the other objectives. I dont see much conflict in between the non-speed objectives.

We would prefer to have some results first to validate if the environments really make sense for MO-Gymnasium. Would it be possible for you to run GPI-LS from more-baselines and report back to us with the learned PFs?

@MaxCunningham19
Copy link
Author

Hi sorry for the delay,

I will do this ASAP, it make take a while as this is not my current top priority. Hope that is ok!

@MaxCunningham19
Copy link
Author

Hi @LucasAlegre sorry I havent gotten around to this have been super busy would you (and the rest of the team) prefer if I closed this PR and opened it back up when I can finish it or just leave it open?

@LucasAlegre LucasAlegre marked this pull request as draft March 3, 2025 14:25
@LucasAlegre
Copy link
Collaborator

Hi @LucasAlegre sorry I havent gotten around to this have been super busy would you (and the rest of the team) prefer if I closed this PR and opened it back up when I can finish it or just leave it open?

Hi, no problem! I changed it to "draft" now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants