Fix mario video not recorded with standard gymnasium RecordVideo#116
Open
JaydenTeoh wants to merge 2 commits intoFarama-Foundation:mainfrom
Open
Fix mario video not recorded with standard gymnasium RecordVideo#116JaydenTeoh wants to merge 2 commits intoFarama-Foundation:mainfrom
JaydenTeoh wants to merge 2 commits intoFarama-Foundation:mainfrom
Conversation
Collaborator
|
Ideally, it would be better if we could modify the Mario env to support the original RecordVideo wrapper. @JaydenTeoh is it impossible? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if anyone observed this but for
gym-super-mario-bros, the standard GymnasiumRecordVideois not able to record videos for it. I spent quite a while on building this wrapper that allow video recording for MOSuperMarioBros and I thought it'll be nice to share.Standard Gymnasium
RecordVideohttps://github.com/user-attachments/assets/00d429bb-cee3-4c1d-bb72-aee1ac492551
NEW
RecordMarioVideohttps://github.com/user-attachments/assets/7d020fb3-cf33-4298-a92f-1d6970909f6b
Made corresponding fix in MORL-Baselines, see LucasAlegre/morl-baselines#137