Fix for spec.to_json() for CrossingEnv (issue #396) #483
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves CrossingEnv, so it's specs can now be stated in JSON-safe way, allowing to serialize them cleanly.
Added coverage to catch spec JSON issues across all MiniGrid environments.
Changes:
minigrid/__init__.py: register CrossingEnv variants with obstacle_type="wall"/"lava" so spec kwargs stay JSON-safe.minigrid/envs/crossing.py: resolve string obstacle types to Wall/Lava, validate subclasses of WorldObj, and consistently use the resolved type for missions and grid generation.tests/test_envs.py: new test_spec_json_serialization ensures every tested env’s spec.to_json() round-trips through json.loads.Fixes #396 (issue)
Type of change
Please delete options that are not relevant.
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist:
pre-commitchecks withpre-commit run --all-files(seeCONTRIBUTING.mdinstructions to set it up)