Skip to content

Conversation

@TTomilin
Copy link
Contributor

@TTomilin TTomilin commented Oct 8, 2025

pettingzoo_wrapper/base_pettingzoo_env.py contains the multi-agent environment wrapper
pettingzoo_wrapper/__init__.py is the main entry point for creating envs
examples/python/multi_agent.py runs a few episodes with rendering for quick validation
examples/python/train_multi_agent.py uses the benchmarl library to train a multi-agent policy

Copy link
Member

@mwydmuch mwydmuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to tests it more, I'm unsure about respawn mechanic.
But I think this is looks good.
What do you think is missing to call it good first version with this one environment?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the change here? I would prefer not to change the scenario we have for such a long time.

})
steps += frames_per_step

elif cmd == "respawn":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if there is respawn delay?

if is_dead:
if verbose:
print(f"Player {agent} respawning at step {game.get_episode_time()}...")
game.respawn_player()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of calling game.respawn_player() that will block the current controller, it is also possible to send "use" action and wait (advance_action) or (make_action).

@TTomilin
Copy link
Contributor Author

I've addressed all the points you've raised. I am not sure about the respawn part. It seems to work fine as is. Needs further testing to see whether there are situations where issues can arise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants