Skip to content

Disable Gymnasium wrapper tests in some workflows#692

Merged
mwydmuch merged 2 commits intomasterfrom
workflows-reduce-tests
Mar 4, 2026
Merged

Disable Gymnasium wrapper tests in some workflows#692
mwydmuch merged 2 commits intomasterfrom
workflows-reduce-tests

Conversation

@mwydmuch
Copy link
Copy Markdown
Member

Because they take too long

@mwydmuch mwydmuch added this to the 1.3.1 milestone Feb 27, 2026
@Trenza1ore
Copy link
Copy Markdown
Contributor

Trenza1ore commented Mar 1, 2026

The gymnasium test cases can sometimes expose platform-specific bug / behavior tho, as they are sort of end-to-end tests. But also yeah, they take like an hour to run on Github Actions, which is too long 🫠

@mwydmuch
Copy link
Copy Markdown
Member Author

mwydmuch commented Mar 4, 2026

@Trenza1ore I hope that the tests for original API are good enough, that they should caught issues that are specific to on specific Python version and os, so Gymnasium test can be run only once. The main motivation is to reduce number of actions minutes we used per PR push as we have some limits as Farama.

@mwydmuch mwydmuch changed the title Disable Gymnasium wrapper tests from some workflows Disable Gymnasium wrapper tests in some workflows Mar 4, 2026
@mwydmuch mwydmuch merged commit 322220a into master Mar 4, 2026
29 checks passed
@Trenza1ore
Copy link
Copy Markdown
Contributor

@Trenza1ore I hope that the tests for original API are good enough, that they should caught issues that are specific to on specific Python version and os, so Gymnasium test can be run only once. The main motivation is to reduce number of actions minutes we used per PR push as we have some limits as Farama.

@mwydmuch 🙂 I see, yep that makes perfect sense. I wonder if it would be possible to have a dedicated workflow for the original cross platform Gymnasium test and you run it not-so-frequently every week/month/version manually?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants