Fix Python API screen buffer uses unblended palette#694
Open
lmBored wants to merge 1 commit intoFarama-Foundation:masterfrom
Open
Fix Python API screen buffer uses unblended palette#694lmBored wants to merge 1 commit intoFarama-Foundation:masterfrom
lmBored wants to merge 1 commit intoFarama-Foundation:masterfrom
Conversation
Author
|
@mwydmuch Hi, I just want to ask if you maybe had a chance to take a look at this PR? :) Thank you in advance. |
Member
|
Hi @lmBored, thanks for bumping this PR. I was quite occupied with other things last two weeks, but I should take a look into this PR by the end of this week. |
Author
|
Interesting, this test passed locally for me (I'm on Mac M series). The flash state timing is system-dependent ig, good that CI runner catches this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on Discord, Python API screen buffer uses
VIZ_CopyBuffer(), this callsscreen->GetPalette()which returns SourcePalette. This is unblended base palette, so functions likeFadeTo()is not visible and doesnt work.