Fix potential vulnerable cloned function #187
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR applies a critical security patch to fix CVE-2020-15890 in the LuaJIT error handling code. The vulnerability existed in the finderrfunc() function where the cframe pointer (cf) was not being advanced in the FRAME_CP case, potentially causing pointer desynchronization during stack traversal.
- Adds missing
cf = cframe_prev(cf);call in theFRAME_CPcase offinderrfunc() - Aligns the
FRAME_CPcase behavior withFRAME_CandFRAME_CONTcases - Directly applies the upstream LuaJIT security patch from commit 53f82e6e2e858a0a62fd1a2ff47e9866693382e6
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our tool detected a potential vulnerability in
finderrfunc()inthird-party/luajit/src/lj_err.cwhich was cloned from LuaJIT/LuaJIT@53f82e6 but did not receive the security patch. The original issue was reported and fixed under CVE-2020-15890.Proposed Fix
Apply the same patch as the one in LuaJIT/LuaJIT to eliminate the vulnerability.
Reference
https://nvd.nist.gov/vuln/detail/CVE-2020-15890
LuaJIT/LuaJIT@53f82e6