Fix: empty data/stable folder in 0.9.7 wheels #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where version 0.9.7 wheels had empty data/stable folders by updating the package data glob patterns to include versioned game folders, and bumps the version to 0.9.8.
- Updated
platform_globsto include patterns for both versioned (*-Platform-v*/*) and non-versioned (*-Platform/*) game data folders - Refactored platform list into a separate variable for better code organization
- Added documentation comment explaining the folder naming convention
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| stable_retro/VERSION.txt | Bumps version from 0.9.7 to 0.9.8 |
| setup.py | Extracts platform list and adds glob patterns for versioned game folders (e.g., Pong-Atari2600-v0/) to fix missing data in wheels |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.