Skip to content

Conversation

@MatPoliquin
Copy link
Collaborator

@MatPoliquin MatPoliquin commented Dec 31, 2025

  • DragonWarrior-Nes (PRG1 version)
  • FinalFantasy-Nes
  • LegendOfZelda-Nes (PRG0 version)
  • PokemonRed-GameBoy

Scenario files are placeholders for now; RPG progress/reward/done logic needs a more robust approach than the current default scenario.json format.

@MatPoliquin MatPoliquin changed the title new games: add 4 RPGs as experimental new games (experimental): add 4 RPGs as experimental Dec 31, 2025
@MatPoliquin MatPoliquin requested a review from Copilot December 31, 2025 15:43
@MatPoliquin MatPoliquin changed the title new games (experimental): add 4 RPGs as experimental Add experimental RPG integrations (4) Dec 31, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds experimental support for 4 classic RPG games to the stable_retro library: Pokemon Red (GameBoy), Legend of Zelda (NES PRG0), Final Fantasy (NES), and Dragon Warrior (NES PRG1). Each game includes save state files, ROM SHA hashes, metadata, memory address mappings, and placeholder scenario files that acknowledge RPG progress tracking requires more sophisticated logic than the current default format supports.

Key Changes

  • Added 4 new experimental RPG game integrations with complete data files
  • Updated README.md to document the newly supported RPG games
  • Included comprehensive memory address mappings (data.json) for each game to expose game state variables

Reviewed changes

Copilot reviewed 17 out of 21 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
README.md Updated to add new RPGs (experimental) row in the games table
stable_retro/data/experimental/PokemonRed-GameBoy/* Complete game integration including state, metadata, ROM hash, memory mappings, and placeholder scenario
stable_retro/data/experimental/LegendOfZeldaPRG0-Nes/* Complete game integration including state, metadata, ROM hash, memory mappings, and placeholder scenario
stable_retro/data/experimental/FinalFantasy-Nes/* Complete game integration including state, metadata, ROM hash, memory mappings, and placeholder scenario
stable_retro/data/experimental/DragonWarriorPRG1-Nes/* Complete game integration including state, metadata, ROM hash, memory mappings, and placeholder scenario

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

README.md Outdated
| BeatEmUps | Streets Of Rage, Double Dragon, TMNT 2: The Arcade Game, Golden Axe, Final Fight |
| Racing | Super Hang On, F-Zero, OutRun |
| RPGs | coming soon |
| RPGs (experimental) | Pokemon Red-GameBoy, LegendOfZelda-Nes, FinalFantasy-Nes, DragonWarrior-Nes |
Copy link

Copilot AI Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The directory name "LegendOfZeldaPRG0-Nes" is inconsistent with the README.md which lists it as "LegendOfZelda-Nes". The directory name includes "PRG0" but this suffix is not reflected in the README documentation. This naming inconsistency could cause confusion for users.

Suggested change
| RPGs (experimental) | Pokemon Red-GameBoy, LegendOfZelda-Nes, FinalFantasy-Nes, DragonWarrior-Nes |
| RPGs (experimental) | Pokemon Red-GameBoy, LegendOfZeldaPRG0-Nes, FinalFantasy-Nes, DragonWarrior-Nes |

Copilot uses AI. Check for mistakes.
README.md Outdated
| BeatEmUps | Streets Of Rage, Double Dragon, TMNT 2: The Arcade Game, Golden Axe, Final Fight |
| Racing | Super Hang On, F-Zero, OutRun |
| RPGs | coming soon |
| RPGs (experimental) | Pokemon Red-GameBoy, LegendOfZelda-Nes, FinalFantasy-Nes, DragonWarrior-Nes |
Copy link

Copilot AI Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The game name "Pokemon Red-GameBoy" in the README uses inconsistent formatting. It should either be "PokemonRed-GameBoy" (matching the directory name) or "Pokemon Red - GameBoy" with proper spacing. The current format "Pokemon Red-GameBoy" has a space before the hyphen but not after.

Suggested change
| RPGs (experimental) | Pokemon Red-GameBoy, LegendOfZelda-Nes, FinalFantasy-Nes, DragonWarrior-Nes |
| RPGs (experimental) | PokemonRed-GameBoy, LegendOfZelda-Nes, FinalFantasy-Nes, DragonWarrior-Nes |

Copilot uses AI. Check for mistakes.
@MatPoliquin MatPoliquin merged commit 06a160d into master Jan 1, 2026
18 checks passed
@MatPoliquin MatPoliquin deleted the rpgs_experimental branch January 1, 2026 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants