-
-
Notifications
You must be signed in to change notification settings - Fork 64
Add experimental RPG integrations (4) #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds experimental support for 4 classic RPG games to the stable_retro library: Pokemon Red (GameBoy), Legend of Zelda (NES PRG0), Final Fantasy (NES), and Dragon Warrior (NES PRG1). Each game includes save state files, ROM SHA hashes, metadata, memory address mappings, and placeholder scenario files that acknowledge RPG progress tracking requires more sophisticated logic than the current default format supports.
Key Changes
- Added 4 new experimental RPG game integrations with complete data files
- Updated README.md to document the newly supported RPG games
- Included comprehensive memory address mappings (data.json) for each game to expose game state variables
Reviewed changes
Copilot reviewed 17 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updated to add new RPGs (experimental) row in the games table |
| stable_retro/data/experimental/PokemonRed-GameBoy/* | Complete game integration including state, metadata, ROM hash, memory mappings, and placeholder scenario |
| stable_retro/data/experimental/LegendOfZeldaPRG0-Nes/* | Complete game integration including state, metadata, ROM hash, memory mappings, and placeholder scenario |
| stable_retro/data/experimental/FinalFantasy-Nes/* | Complete game integration including state, metadata, ROM hash, memory mappings, and placeholder scenario |
| stable_retro/data/experimental/DragonWarriorPRG1-Nes/* | Complete game integration including state, metadata, ROM hash, memory mappings, and placeholder scenario |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
README.md
Outdated
| | BeatEmUps | Streets Of Rage, Double Dragon, TMNT 2: The Arcade Game, Golden Axe, Final Fight | | ||
| | Racing | Super Hang On, F-Zero, OutRun | | ||
| | RPGs | coming soon | | ||
| | RPGs (experimental) | Pokemon Red-GameBoy, LegendOfZelda-Nes, FinalFantasy-Nes, DragonWarrior-Nes | |
Copilot
AI
Dec 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The directory name "LegendOfZeldaPRG0-Nes" is inconsistent with the README.md which lists it as "LegendOfZelda-Nes". The directory name includes "PRG0" but this suffix is not reflected in the README documentation. This naming inconsistency could cause confusion for users.
| | RPGs (experimental) | Pokemon Red-GameBoy, LegendOfZelda-Nes, FinalFantasy-Nes, DragonWarrior-Nes | | |
| | RPGs (experimental) | Pokemon Red-GameBoy, LegendOfZeldaPRG0-Nes, FinalFantasy-Nes, DragonWarrior-Nes | |
README.md
Outdated
| | BeatEmUps | Streets Of Rage, Double Dragon, TMNT 2: The Arcade Game, Golden Axe, Final Fight | | ||
| | Racing | Super Hang On, F-Zero, OutRun | | ||
| | RPGs | coming soon | | ||
| | RPGs (experimental) | Pokemon Red-GameBoy, LegendOfZelda-Nes, FinalFantasy-Nes, DragonWarrior-Nes | |
Copilot
AI
Dec 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The game name "Pokemon Red-GameBoy" in the README uses inconsistent formatting. It should either be "PokemonRed-GameBoy" (matching the directory name) or "Pokemon Red - GameBoy" with proper spacing. The current format "Pokemon Red-GameBoy" has a space before the hyphen but not after.
| | RPGs (experimental) | Pokemon Red-GameBoy, LegendOfZelda-Nes, FinalFantasy-Nes, DragonWarrior-Nes | | |
| | RPGs (experimental) | PokemonRed-GameBoy, LegendOfZelda-Nes, FinalFantasy-Nes, DragonWarrior-Nes | |
Scenario files are placeholders for now; RPG progress/reward/done logic needs a more robust approach than the current default scenario.json format.