Fix: resolve "Cannot read property 'filter' of undefined" error #967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavianusb
suggested changes
Mar 31, 2025
| if ( | ||
| shouldDisplayPredefinedPlaces || | ||
|
|
||
| const isPredefinedPlaceVisible = |
There was a problem hiding this comment.
I guess you can simplify this as:
Suggested change
| const isPredefinedPlaceVisible = | |
| const isPredefinedPlaceVisible = !!props?.predefinedPlacesAlwaysVisible; |
Comment on lines
+75
to
+78
| const onTimeoutFunc = () => console.warn('google places autocomplete: request timeout'); | ||
| const onTimeout = props.onTimeout ?? onTimeoutFunc; | ||
| const timeout = props.timeout ?? 20000; | ||
|
|
There was a problem hiding this comment.
you can change this with:
Suggested change
| const onTimeoutFunc = () => console.warn('google places autocomplete: request timeout'); | |
| const onTimeout = props.onTimeout ?? onTimeoutFunc; | |
| const timeout = props.timeout ?? 20000; | |
| const onTimeoutFunc = () => console.warn('google places autocomplete: request timeout'); | |
| const { timeout = 20000, onTimeout = onTimeoutFunc } = props; | |
Comment on lines
+285
to
+287
| const onTimeout = () => console.warn('google places autocomplete: request timeout'); | ||
| request.timeout = props.timeout ?? 20000; | ||
| request.ontimeout = props.onTimeout ?? onTimeout |
There was a problem hiding this comment.
this will became:
Suggested change
| const onTimeout = () => console.warn('google places autocomplete: request timeout'); | |
| request.timeout = props.timeout ?? 20000; | |
| request.ontimeout = props.onTimeout ?? onTimeout | |
| request.timeout = timeout; | |
| request.ontimeout = onTimeout; |
| : text.length >= 0 | ||
| : false | ||
|
|
||
| console.log(isSearchTerm) |
| @@ -327,29 +332,16 @@ export const GooglePlacesAutocomplete = forwardRef((props, ref) => { | |||
| } | |||
| }; | |||
|
|
|||
| if (props.isNewPlacesAPI) { | |||
There was a problem hiding this comment.
Why are you deleting the support for PlacesAPI new version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.