Add optional property for @JacksonInject to allow optionally injected values
#291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cowtowncoder
reviewed
May 1, 2025
cowtowncoder
reviewed
May 1, 2025
src/main/java/com/fasterxml/jackson/annotation/JacksonInject.java
Outdated
Show resolved
Hide resolved
cowtowncoder
reviewed
May 1, 2025
src/main/java/com/fasterxml/jackson/annotation/JacksonInject.java
Outdated
Show resolved
Hide resolved
|
Looks pretty good -- couple of small things but that's fine. Before merging this, one process thing: if I haven't asked for and gotten CLA, it is needed before merge: https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf and the usual way is to print it, fill & sign, scan/photo, email to This only needs to be done once and CLA is good for all future contributions. Looking forward getting this & related PR merged! |
cowtowncoder
changed the title
optional property for @JacksonInject to allow optionally injected values
|
CLA received. |
cowtowncoder
reviewed
May 2, 2025
| * | ||
| * @since 2.20 | ||
| */ | ||
| public OptBoolean optional() default OptBoolean.FALSE; |
There was a problem hiding this comment.
Actually I'll change default to OptBoolean.DEFAULT.
cowtowncoder
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in jackson-databind#3072, introducing the
optionalflag to@JacksonInjectto avoid throwing an exception if an injected property is not found in the injectable values provided to the object reader: