Skip to content

Conversation

@Fdawgs
Copy link
Owner

@Fdawgs Fdawgs commented Nov 27, 2025

Checklist

Copilot AI review requested due to automatic review settings November 27, 2025 14:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves test coverage for the Poppler constructor by refining Istanbul ignore comments to more precisely identify OS-specific code paths while enabling coverage of the error handling logic.

  • Removed ignore comments from testable code paths (constructor binPath check and error throw)
  • Repositioned ignore comments to precisely mark OS-specific operations (spawnSync and Windows-specific fallback)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@Fdawgs Fdawgs merged commit 4194504 into main Nov 27, 2025
17 checks passed
@Fdawgs Fdawgs deleted the test/coverage branch November 27, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants