refactor(index): freeze #acceptedOptions objects
#739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR introduces object freezing for the #acceptedOptions configuration objects stored in the Poppler class to prevent accidental modifications. While the intent is good defensive programming, the implementation uses a new external dependency ice-barrage instead of JavaScript's built-in Object.freeze().
Key Changes
- Added
ice-barrage^1.0.0 as a production dependency - Wrapped all
#acceptedOptionsobject literals withfreeze()calls across 11 PDF utility method configurations (pdfAttach, pdfDetach, pdfFonts, pdfImages, pdfInfo, pdfSeparate, pdfToCairo, pdfToHtml, pdfToPpm, pdfToPs, pdfToText, pdfUnite)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Added ice-barrage ^1.0.0 dependency for object freezing functionality |
| src/index.js | Imported freeze from ice-barrage and wrapped all accepted options configurations with freeze() calls to make them immutable |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst it is a private field, it is still possible to accidentally change these values, so protect against that.
Checklist
npm test